fix: sync remove item may changed clone btree; (i+1) children has new… #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cow, but do not copy; btree to btree generic Signed-off-by: zhangchuanqing1 <[email protected]>
|
I don't understand this fix. We are only copying the data inside mergeChild, why do we need mutableFor? In your comment in #58, t1 cannot modify any node shared between the trees (it will copy-on-write). Can you produce an exact example that reproduces a problem? By the way, any fix should include a unit test that would have failed without the fix. (posted the same in #58) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… cow, but do not copy; btree to btree generic